Added prefix to global delegates: FOnConnectDelegate, FOnDisconnectDe…#3682
Closed
UmarM-Arvika wants to merge 4 commits into
Closed
Conversation
…e-prefix for the generate command to support it
…legate, FOnSubscriptionApplied, FOnSubscriptionError
|
|
JasonAtClockwork
force-pushed
the
jlarabie/unreal-multimodule
branch
from
6a0ab69 to
0b00fb8
Compare
JasonAtClockwork
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
Contributor
|
I've manually merged this in as there was very large changes that I needed to rebase from and added a couple missed delegates for the table insert/update/delete. Thanks for this work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added prefix to global delegates
Description of Changes
Some global delegates needed prefix in order to work in MultiModule scenario
API and ABI breaking changes
N/A
Expected complexity level and risk
1 - This only adds prefix to four global delegates
Testing
Generete multiple module bindings for an Unreal Engine project and include all the {ModulePefix}SpacetimeDBClient.g.h in a single translation unit.